rockyou | exports the rockyou passwords for security testing | Security library

I am having a problem creating a list with askopenfile() with a password file. I have it working with usernames but since rockyou.txt and password files have special characters I had to convert it to UTF-8 and the same method I am using for usernames is producing a list character by character rather then word by word.

user name:

I am creating script which reads from rockyou.txt file and the problem is that when it finishes going through all lines - 1.5M then it continues reading empty lines from the file and i need it to stop.

I can't do a simple if statement to check if the line is empty because in the file there are multiple places where there is a single empty line.

Do you have any ideas how to implement?

Code:

Below I have been working on a Excel password recovery tool for work as we have had a few occasions where project managers have password protected excels and then forgot the password and they have lost weeks of work because of this.

The below code seems to be running but doesn't get past the first word in the wordlist and then paste that the password has been found.

Example of output:

in cmd

I'm trying to do to a test launch of hashcat with these two passwords:

First off, this is not for an assignment, this is a side tangent project to help with my shell knowledge. I am trying to make a simple shell script that, when given a text file of commands, runs each one in order until the one before it is done.

So far I have come up with:

I'm currently writing a password cracker in Python and was thinking about the best strategy for searching a dictionary of password hashes, based on a downloaded wordlist.

Password lists such as rockyou are ordered in terms of most common passwords, so my initial approach was to search the dictionary in order, in case the hash I'm trying to crack is one that corresponds to a very common password that is at the top of the list. However, I was thinking that for less common passwords this linear search could take a very long time, so I was considering implementing a binary search. Would this be faster overall, or would a linear search be quicker on average (given that many passwords will be at the top of the list?)

Would it be a sensible strategy to do a linear search over the top 100 or so passwords, and then switch to binary search if not found?

Currently working on a string search program for a uni module, and I've managed to implement the algorithms successfully, at least to the point where they're finding the string consistently. I implemented Boyer Moore and Rabin Karp. I also threw in a Brute Force when one of my coursemates experienced this exact problem, and realised I had the same issue - that brute force is faster than Rabin-Karp on a wordlist.

Rabin-Karp seems to be taking the most amount of time performing the rolling hash, I was curious at first if I was just having a lot of collisions, but I managed to get collisions down to 3 with a huge prime number. That added on a little bit of time I'm assuming due to the size of the prime number, but it seemed pretty clear that rolling hash was causing the problem.

This is the rolling hash section:

I'm trying to write a piece of code in C which takes an input(as string) from the file and adds it at the end of another string and prints it. The program compiles perfectly in Visual Studio 2013 but crashes during run. Can anyone please help me identify the problem with the code.

Here is the code: