Text-RPG | Text RPG created as a fun project | Data Manipulation library

The correct method would be to use iterators. Don't pass pointer of 'Item' in

void AddItem(Item* item) method.

You should create an iterator of 'Item' class and pass this iterator to "AddItem" method. Similarly create another method "RemoveItem" that returns an iterator of 'Item' that can be sent to Player's "CollectMoney" method.

If you don't want to use iterators, you can use "Item * item" as well but you have to call a method "RemoveItem" to get the reference of the "Item" so you can pass it to Player. Since the Items are not created inside the class, they should not be deleted in the class so remove the destructor.

PS use this constructor -> Inventory() {items.resize(10,nullptr);}