21-points | ❤️ 21-Points Health is an app you can use to monitor | Security library

I encountered (and resolved) a significant JHipster upgrade error. My questions are simple, but there is a little setup and back story first, so I'm going to break this into pieces.

(0) Dev Environment
(1) Upgrade Problem
(2) Investigation/fix strategy
(3) Solution
(4) Questions

Windows 10, Gradle 5.4.1, node 10.16.3, npm 6.11.2, yarn 1.16.0, MariaDB 10.3, JDK 11, IntelliJ 2019.2.2, git 2.23.0

My project: monolithic app, using Gradle, Angular, JWT authentication, MariaDB for BOTH test and production, no search.

My code is the 21-Points project as outlined in Matt Raible's book: The JHipster Mini-Book v5.0.3. I started my development with JHipster 6.0. Over the summer, I have periodically reviewed the code, and applied upgrades: 6.0.1 to 6.1.1 to 6.1.2 (in each case, after resolving a handful of conflicts, the project would compile and run without hitch).

Last week, I noticed the release of JHipster 6.2.0. I made a copy/backup of the 6.1.2 working code, updated the generator(npm update -g generator-jhipster), applied the upgrade (jhipster upgrade), resolved the conflicts, and... fail. The stacktrace is fairly long and involved. If anyone likes, I'll add it to the post later. But, essentially, the tests failed, and the application would not launch (resulting only in an error page: "An error has occurred :-(", followed by lengthy text suggesting what might have gone wrong, and suggested fixes).

Reverting to the original code, everything still works. Performing a comparison of the two projects, the only changes are those associated with the upgrade. Being surprised by the failure, I scratched my head, then did the following.

At this point I had two versions of my project, which I shall label as: 6.1.2-working (the original code before the upgrade) and 6.2.0-broken (the original code + the Jhipster upgrade).

I created a third new fresh project (which I shall refer to as 6.2.0-fresh) as follows:

• Created a new directory
• Copied the 6.1.2-working .yo-rc.json file into it, along with a JDL file (21points.jh)
• From bash, typed:
  • jhipster
  • jhipster import-jdl 21points.jh
  • npm install ng2-nvd3 <-- because Matt Raible makes use of some graph plotting

I then carried out a diff between 6.1.2-working and 6.2.0-fresh, and migrated the functional changes from 6.1.2-working to 6.2.0-fresh. Eventually, I got the new 6.2.0-fresh to run as expected. Theoretically, I could have left things there, but:

• I wanted to find a proper upgrade solution, rather than a "port".
• This method fails to preserve my version control history. For a normal project, I need to keep that.

I carried out a diff between the new 6.2.0-fresh and 6.2.0-broken. The ONLY meaningful difference was a change in a particular file: package-lock.json

Simply:

• copy the new package-lock.json file into the 6.2.0-broken root directory
• delete the 6.2.0-broken node_modules directory
• type: npm install (to rebuild the node_modules directory)

I could now build/run the 6.2.0-broken project without a problem!

To upgrade from JHipster 6.1.2 to 6.2.0:

• (Make a backup/copy of your working project code... always a good idea)
• Carry out the JHipster upgrade:
  • npm update -g generator-jhipster
  • jhipster upgrade
  • Find/resolve any conflicts generated by the upgrade process
• Create a new temporary directory
• Copy your original .yo-rc.json file into it, along with any JDL files
• From bash, in the temporary root, type:
  • jhipster
  • jhipster import-jdl (...your JDL files...)
  • npm install (...needed modules...)
• Make sure the temporary project works: ./gradlew integrationTest
• Copy/overwrite the newly created package-lock.json file from the temporary project root to your working project root
• Delete the node_modules directory from your working project root
• Type: npm install
• Build/test/run your project, and enjoy

Everything should now work nicely.

• Is the problem I experienced common?
• Does anyone know why this occurred? Is this a problem with the JHipster upgrade process? Or, is it a natural by-product of JHipster upgrades that everyone already knows about (though undocumented on the JHipster site), and which I was simply lucky to have not bumped into previously?
• Did I miss something in my upgrade? Did I do something wrong?
• Is my solution appropriate? Are there potential problems with it?
• Is there a better way to resolve upgrade issues like this? A "standard operating procedure" to upgrade such projects?

Thanks!