solang | Solidity Compiler for Solana , Substrate , and ewasm | Blockchain library

The tech-lead is wrong: your code is perfectly efficient the way it is written. Making the code shorter does not make it faster or more "elegant".

However, shorter code can be easier to maintain and change. Your code is fine as long as the number of heart containers is always exactly 12. But if you want to change that (to increase/decrease the difficultly of the game, or let the player get new heart containers) then this code won't work. It is hard-coded to work with exactly 12 heart containers only.

To change this, put this repetitive code in a loop. You'll need to look at the pattern of how the numbers change and create a small math formula for it. I've come up with the following. (I've also added constants instead of the integer literals, so that the code is easier to read and change.)

Don't create set the dataframe during the loop. The strategy is to collect records into a list of dictionary and the end, create your dataframe.

New code (search # <- HERE)

You need to use the same ViewRouter instance across the whole app.

In the TopicCell view you're creating a new instance of ViewRouter:

You can use groupby to group by country and city, and then summing all the rest:

Here are two possible solutions. First dataframe is df and second dataframe is df1.

First method : pd.concat

Remove the cast of ArrayList or System.String for the $Hosts parameter, and use foreach in your code to iterate each item, it will handle it alone...

See example:

Maybe I am missing something, but as far as I can see you just have to use i instead of site (you are looping trough the list of sites after all).

domain = urlparse(site).netloc and scraper = scrape_me(site) at least.

EDIT:

In addition to your comment - you are actually saving the last result 3 times since you are doing it in a separate for loop. The way to fix this would be to restructure your code and put everything in one for loop:

Before you start the loop:
with open('test.csv', "w", encoding="utf-8") as recipes_file:

Inside the loop:
recipe_writer = csv.writer(recipes_file, delimiter=',', quotechar='"', quoting=csv.QUOTE_MINIMAL)
recipe_writer.writerow([title, total_time, ingredients, instructions, image])