zealot | Air Server for deployment of Android and iOS apps | Continuous Deployment library

std::vector resizes when the code does philosophers.emplace_back(), which can move the elements in memory, so that their previous addresses become invalid and the feed() function ends up accessing objects using their old invalid addresses.

A fix would be to make the philosopher class non-copyable and non-movable, and then use std::list or std::forward_list instead of std::vector. std::list and std::forward_list do not move elements in memory and hence are capable of storing non-copyable and non-moveable objects.

You may also like to use std::thread instead of pthread_t, and std::mutex instead of pthread_mutex_t. The std classes are non-copyable/movable which would prevent you from making this error at compile-time. Also, the code doesn't check return values of the pthread functions for errors, whereas std::thread and std::mutex do that for you.