Mockingjay | elegant library for stubbing HTTP requests | Mock library

Subtraction is for numeric operations. Use a.title.localeCompare(b.title) instead.

A couple of issues:

1. The pattern is that leave must be called inside the completion handler of the asynchronous call. You want this to be the last thing performed inside the closure, so you could add it as the the last line within completion handler closure.

   Or I prefer to use a defer clause, so that not only do you know it will be the last thing performed in the closure, but also:

   • you ensure you leave even if you later add any "early exits" inside your closure; and
   • the enter and leave calls visually appear right next to each other in the code saving you from having to visually hunt down at the bottom of the closure to make sure it was called correctly.

2. You also, if you want to wait for the asynchronous calls in the for loop, have to add it there, too.

3. A very minor point, but you might want to not create the group until you successfully unwrapped uid. Why create the DispatchGroup if you could possibly return and not do any of the asynchronous code?

Thus, perhaps:

When I write code like this, I try to make things as simple as possible. I put code that is going to be reused into functions to that they are easier to call and easier to maintain.

In your case, you are looping through all the TDs looking for an element that contains text that matches the product you are looking for. Rather than doing this, we can search for the specific element using an XPath.

Your if statement will never be true, you are comparing an object and a string