tonks | An alternative system scheduler for Legion ECS | Game Engine library

Your code was really close to working (btw would not compile in the form it had been copied into the question)... but rather than fully debugging it, I took the approach of cleaning it up until it worked; there was a lot of code that was redundant.

The code below reads though all assignment folders/student folders and email messages ... and creates the assignment sub directories, and the student directories within those, and saves attachments within the assignment/student directory. It updates the email body with the references to the saved attachment(s).

If you wanted it work for only selected folders, you'll need to tweak the below code a bit.

I suspect that the issue with the duplicate directory names is possibly due to incompatible characters from the student's email address being put into the student's directory path name ... so I've included a very primitive cleaning function (which I didn't test all too much) to hopefully avoid that;it may need tweaking.

Incidentally, I use early binding so you'll need to add a reference to the MS scripting runtime if you don't already have it.